verifier: verify platforms of the build result #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
platforms-verify
branch
from
282abd3
to
c4693fe
Compare
thompson-shaun
added
kind/enhancement
status/code-review
needs/follow-up
and removed
needs/follow-up
labels
crazy-max
requested changes
May 30, 2024
Check that the result returned from the frontend matches the user request conventions and show a warning if it doesn't. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
platforms-verify
branch
from
c4693fe
to
acb1bed
Compare
crazy-max
approved these changes
May 31, 2024
|
@crazy-max This protects against frontend (or client gateway callback) not handling the |
crazy-max
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the result returned from the frontend
matches the user request conventions and show a
warning if it doesn't.
I'll be following up to this with verification on image metadata (if image is exported) as well. Currently, in some cases image platform gets reset even if using
FROM --platformand a new metadata field would need to be passed from Dockerfile, so leaving this to future changes.